HaoYang670 commented on code in PR #5337:
URL: https://github.com/apache/arrow-datafusion/pull/5337#discussion_r1117884001
##########
datafusion/optimizer/src/push_down_filter.rs:
##########
@@ -511,25 +511,20 @@ impl OptimizerRule for PushDownFilter {
"push_down_filter"
}
+ fn apply_order(&self) -> Option<ApplyOrder> {
+ Some(ApplyOrder::TopDown)
+ }
+
fn try_optimize(
&self,
plan: &LogicalPlan,
- config: &dyn OptimizerConfig,
+ _config: &dyn OptimizerConfig,
Review Comment:
> just because it's only used recursively
In the original code, we pass the `config` to the `optimize_children`, but
now, it is just a placeholder for self recursion, which means we never use the
`config` anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
