emkornfield commented on code in PR #34054:
URL: https://github.com/apache/arrow/pull/34054#discussion_r1118482264
##########
cpp/src/parquet/column_writer.cc:
##########
@@ -1482,15 +1538,14 @@ class TypedColumnWriterImpl : public ColumnWriterImpl,
public TypedColumnWriter<
void WriteValuesSpaced(const T* values, int64_t num_values, int64_t
num_spaced_values,
const uint8_t* valid_bits, int64_t valid_bits_offset,
- int64_t num_levels) {
+ int64_t num_levels, int64_t num_nulls) {
Review Comment:
we should clarify what num_nulls means here. We've had problem in the past
on interpretation of empty-lists as nulls (I believe this is what the parquet
spec expects), and num_null I think it usually derived from Arrow's concept but
i could be mistaken.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
