tustvold commented on code in PR #3741:
URL: https://github.com/apache/arrow-rs/pull/3741#discussion_r1118710199


##########
object_store/src/aws/mod.rs:
##########
@@ -1222,6 +1252,14 @@ mod tests {
         stream_get(&integration).await;
     }
 
+    #[tokio::test]
+    async fn s3_test_unsigned_payload() {

Review Comment:
   I would rather avoid additional test dependencies if possible. I see no 
issue with just merging this into the same test as above



##########
object_store/src/aws/mod.rs:
##########
@@ -1222,6 +1252,14 @@ mod tests {
         stream_get(&integration).await;
     }
 
+    #[tokio::test]
+    async fn s3_test_unsigned_payload() {

Review Comment:
   I would rather avoid additional test dependencies if possible. I see no 
issue with just merging this into the same test as above, the stack trace will 
make it clear what test failed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to