thisisnic commented on PR #34340: URL: https://github.com/apache/arrow/pull/34340#issuecomment-1446490563
> Thank you for your review. > > I have changed the order of the arguments and have changed the order of the list in the documentation too in [94b41eb](https://github.com/apache/arrow/commit/94b41eb56518e478109e226bd138f5057056479d). However, it may be easier to understand if `skip` and `skip_rows_after_names` were side by side in documents. If you think so, please let me know. (I have no strong opinions about it) I absolutely agree that it would make a lot more sense if they were side-by-side in documentation such as vignettes. I don't think we currently mention these options in the vignettes at all, but that could make for a really helpful follow-up issue/PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
