wjones127 commented on code in PR #34133: URL: https://github.com/apache/arrow/pull/34133#discussion_r1118948166
########## csharp/test/Apache.Arrow.Tests/CDataInterfaceSchemaTests.cs: ########## @@ -0,0 +1,302 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +// contributor license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright ownership. +// The ASF licenses this file to You under the Apache License, Version 2.0 +// (the "License"); you may not use this file except in compliance with +// the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +using System; +using System.Collections; +using System.Collections.Generic; +using System.Linq; +using System.Runtime.InteropServices; +using Apache.Arrow.C; +using Apache.Arrow.Types; +using Python.Runtime; +using Xunit; + +namespace Apache.Arrow.Tests +{ + public class CDataSchemaTest + { + public CDataSchemaTest() + { + PythonEngine.Initialize(); + } + + public static Schema GetTestSchema() + { + // TODO: Add more types + using (Py.GIL()) + { + var schema = new Schema.Builder() + .Field(f => f.Name("null").DataType(NullType.Default).Nullable(true)) + .Field(f => f.Name("bool").DataType(BooleanType.Default).Nullable(true)) + .Field(f => f.Name("i8").DataType(Int8Type.Default).Nullable(true)) + .Field(f => f.Name("u8").DataType(UInt8Type.Default).Nullable(true)) + .Field(f => f.Name("i16").DataType(Int16Type.Default).Nullable(true)) + .Field(f => f.Name("u16").DataType(UInt16Type.Default).Nullable(true)) + .Field(f => f.Name("i32").DataType(Int32Type.Default).Nullable(true)) + .Field(f => f.Name("u32").DataType(UInt32Type.Default).Nullable(true)) + .Field(f => f.Name("i64").DataType(Int64Type.Default).Nullable(true)) + .Field(f => f.Name("u64").DataType(UInt64Type.Default).Nullable(true)) + + .Field(f => f.Name("f16").DataType(HalfFloatType.Default).Nullable(true)) + .Field(f => f.Name("f32").DataType(FloatType.Default).Nullable(true)) + .Field(f => f.Name("f64").DataType(DoubleType.Default).Nullable(true)) + + .Field(f => f.Name("binary").DataType(BinaryType.Default).Nullable(false)) + .Field(f => f.Name("string").DataType(StringType.Default).Nullable(false)) + + .Field(f => f.Name("date32").DataType(Date32Type.Default).Nullable(false)) + .Field(f => f.Name("date64").DataType(Date64Type.Default).Nullable(false)) + .Field(f => f.Name("time32_s").DataType(new Time32Type(TimeUnit.Second)).Nullable(false)) + .Field(f => f.Name("time32_ms").DataType(new Time32Type(TimeUnit.Millisecond)).Nullable(false)) + .Field(f => f.Name("time64_us").DataType(new Time64Type(TimeUnit.Microsecond)).Nullable(false)) + .Field(f => f.Name("time64_ns").DataType(new Time64Type(TimeUnit.Nanosecond)).Nullable(false)) + + .Field(f => f.Name("list_string").DataType(new ListType(StringType.Default)).Nullable(false)) + .Field(f => f.Name("list_list_i32").DataType(new ListType(new ListType(Int32Type.Default))).Nullable(false)) + + .Field(f => f.Name("dict_string").DataType(new DictionaryType(Int32Type.Default, StringType.Default, false)).Nullable(false)) + .Field(f => f.Name("dict_string_ordered").DataType(new DictionaryType(Int32Type.Default, StringType.Default, true)).Nullable(false)) + .Field(f => f.Name("list_dict_string").DataType(new ListType(new DictionaryType(Int32Type.Default, StringType.Default, false))).Nullable(false)) + + .Build(); + return schema; + } + } + + public static IEnumerable<dynamic> GetPythonFields() + { + using (Py.GIL()) + { + dynamic pa = Py.Import("pyarrow"); + yield return pa.field("null", pa.GetAttr("null").Invoke(), true); + yield return pa.field("bool", pa.bool_(), true); + yield return pa.field("i8", pa.int8(), true); + yield return pa.field("u8", pa.uint8(), true); + yield return pa.field("i16", pa.int16(), true); + yield return pa.field("u16", pa.uint16(), true); + yield return pa.field("i32", pa.int32(), true); + yield return pa.field("u32", pa.uint32(), true); + yield return pa.field("i64", pa.int64(), true); + yield return pa.field("u64", pa.uint64(), true); + + yield return pa.field("f16", pa.float16(), true); + yield return pa.field("f32", pa.float32(), true); + yield return pa.field("f64", pa.float64(), true); + + yield return pa.field("binary", pa.binary(), false); + yield return pa.field("string", pa.utf8(), false); + + yield return pa.field("date32", pa.date32(), false); + yield return pa.field("date64", pa.date64(), false); + yield return pa.field("time32_s", pa.time32("s"), false); + yield return pa.field("time32_ms", pa.time32("ms"), false); + yield return pa.field("time64_us", pa.time64("us"), false); + yield return pa.field("time64_ns", pa.time64("ns"), false); + + yield return pa.field("list_string", pa.list_(pa.utf8()), false); + yield return pa.field("list_list_i32", pa.list_(pa.list_(pa.int32())), false); + + yield return pa.field("dict_string", pa.dictionary(pa.int32(), pa.utf8(), false), false); + yield return pa.field("dict_string_ordered", pa.dictionary(pa.int32(), pa.utf8(), true), false); + yield return pa.field("list_dict_string", pa.list_(pa.dictionary(pa.int32(), pa.utf8(), false)), false); + } + } + + public static dynamic GetPythonSchema() + { + using (Py.GIL()) + { + dynamic pa = Py.Import("pyarrow"); + return pa.schema(GetPythonFields().ToList()); + } + } + + // Schemas created in Python, used in CSharp + [Fact] + public void ImportType() + { + PythonEngine.Initialize(); + Schema schema = GetTestSchema(); + IEnumerable<dynamic> py_fields = GetPythonFields(); + + foreach ((Field field, dynamic py_field) in schema.Fields.Values.AsEnumerable() + .Zip(py_fields)) + { + var c_schema = new CArrowSchema(); + IntPtr imported_ptr = c_schema.AllocateAsPtr(); + + using (Py.GIL()) + { + dynamic py_datatype = py_field.type; + py_datatype._export_to_c(imported_ptr.ToInt64()); + } + + var dataTypeComparer = new ArrayTypeComparer(field.DataType); + var imported_type = new ImportedArrowSchema(imported_ptr); Review Comment: That's a good point. I need to fix the code style. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
