rok commented on code in PR #34323:
URL: https://github.com/apache/arrow/pull/34323#discussion_r1119458579
##########
cpp/src/parquet/encoding_benchmark.cc:
##########
@@ -569,6 +569,126 @@
BENCHMARK(BM_DeltaBitPackingDecode_Int64_Narrow)->Range(MIN_RANGE, MAX_RANGE);
BENCHMARK(BM_DeltaBitPackingDecode_Int32_Wide)->Range(MIN_RANGE, MAX_RANGE);
BENCHMARK(BM_DeltaBitPackingDecode_Int64_Wide)->Range(MIN_RANGE, MAX_RANGE);
+void EncodingByteArrayBenchmark(benchmark::State& state, Encoding::type
encoding) {
+ ::arrow::random::RandomArrayGenerator rag(0);
+ // Using arrow generator to generate random data.
+ int32_t max_length = state.range(0);
Review Comment:
This appears to be implicit casting and causes [CI to
complain](https://github.com/apache/arrow/actions/runs/4275778292/jobs/7443378150#step:11:1503).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
