korowa commented on PR #5339: URL: https://github.com/apache/arrow-datafusion/pull/5339#issuecomment-1447708169
Thank you for the review @alamb! > I think we should also add sql level test for the memory limit code in; I think it should be easy to add one to https://github.com/apache/arrow-datafusion/blob/main/datafusion/core/tests/memory_limit.rs. I am happy to add such a test if you prefer as a follow on PR. Seems like new `test_overallocation` is sort of duplicate of `memory_limit` tests -- so, I guess, it'll be better to add new `memory_limit` test instead of existing one in this PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
