alamb commented on a change in pull request #8682:
URL: https://github.com/apache/arrow/pull/8682#discussion_r526488579



##########
File path: rust/parquet/src/file/metadata.rs
##########
@@ -433,6 +433,21 @@ impl ColumnChunkMetaData {
         self.dictionary_page_offset
     }
 
+    /// Returns the offset and length in bytes of the column chunk within the 
file

Review comment:
       Looks good to me. @sunchao  do you have any hesitation about hoisting 
this part of the code into the public API? I reviewed the logic carefully and 
it looks like a straight forward port




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to