zeroshade commented on PR #34331: URL: https://github.com/apache/arrow/pull/34331#issuecomment-1448533949
There is possibly some value in having the separate Flight SQL <--> `database/sql` here, as far as contributing goes, though I'd prefer more reasoning than just an "in principle" argument against the extra layers. That said, it's likely not *too* much maintenance overhead to maintain this implementation assuming we get it right. @srebhan If we can get this to a better spot with good testing, I'd be okay with getting this merged. But I do want to make it clear that the documentation / examples will likely still be pointing at using the ADBC implementation. I've already left a bunch of comments above that need to be addressed (above and beyond the failing CI). In addition, I'd prefer if this were put into it's own subdirectory of the `flightsql` directory rather than directly in the `flightsql` package itself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
