mingmwang commented on code in PR #5430:
URL: https://github.com/apache/arrow-datafusion/pull/5430#discussion_r1121218622
##########
datafusion/expr/src/logical_plan/plan.rs:
##########
@@ -1776,6 +1776,40 @@ impl Aggregate {
_ => plan_err!("Could not coerce into Aggregate!"),
}
}
+
+ /// Check whether it is a Distinct.
+ /// A Distinct means all fields of the schema are the expressions of group
by.
Review Comment:
I also feel confusing to the naming and the implementation of this method.
Maybe we should call this `is_group_by_only()` ?
And as alamb mentioned, `SELECT a ... GROUP BY a, a ` should be the group
by only aggregation also.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
