Dandandan commented on a change in pull request #8710:
URL: https://github.com/apache/arrow/pull/8710#discussion_r526508067
##########
File path: rust/arrow/src/csv/reader.rs
##########
@@ -77,15 +70,20 @@ fn infer_field_schema(string: &str) -> DataType {
return DataType::Utf8;
}
// match regex in a particular order
- if BOOLEAN_RE.is_match(string) {
- DataType::Boolean
- } else if DECIMAL_RE.is_match(string) {
- DataType::Float64
- } else if INTEGER_RE.is_match(string) {
- DataType::Int64
- } else {
- DataType::Utf8
+ let lower = string.to_ascii_lowercase();
Review comment:
Would be good in that case to have a benchmark.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
