tustvold commented on code in PR #3778:
URL: https://github.com/apache/arrow-rs/pull/3778#discussion_r1121798184
##########
arrow-array/src/array/dictionary_array.rs:
##########
@@ -249,23 +249,15 @@ impl<K: ArrowPrimitiveType> DictionaryArray<K> {
// Note: This use the ArrayDataBuilder::build_unchecked and afterwards
// call the new function which only validates that the keys are in
bounds.
- let mut data = ArrayData::builder(dict_data_type)
Review Comment:
This was actually previously wrong, as it doesn't preserve the offset of the
input array
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
