paleolimbot commented on code in PR #34399:
URL: https://github.com/apache/arrow/pull/34399#discussion_r1121852588


##########
r/NEWS.md:
##########
@@ -19,6 +19,10 @@
 
 # arrow 11.0.0.9000
 
+## Minor improvements and fixes

Review Comment:
   I always forget the details, but having a blank line before and after a 
markdown "thing" is usually a good idea (/more consistent with the rest of the 
file).



##########
r/NEWS.md:
##########
@@ -19,6 +19,10 @@
 
 # arrow 11.0.0.9000
 
+## Minor improvements and fixes
+* `open_csv_dataset()` allows a schema to be specified. (#34217)
+* to ensure compatibility with an upcoming dplyr release, we no longer call 
`dplyr:::check_names()` (#34369)

Review Comment:
   ```suggestion
   * To ensure compatibility with an upcoming dplyr release, we no longer call 
`dplyr:::check_names()` (#34369)
   ```
   
   (Also make sure this line doesn't exceed 80 characters. I forget exactly 
which R CMD check option will error if it isn't, but I've had a submission 
rejected once because of an "improperly" formatted NEWS.md file and I think 
that was it)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to