rtpsw commented on code in PR #34311: URL: https://github.com/apache/arrow/pull/34311#discussion_r1122287793
########## cpp/src/arrow/compute/exec/options.h: ########## @@ -199,21 +199,39 @@ class ARROW_EXPORT ProjectNodeOptions : public ExecNodeOptions { std::vector<std::string> names; }; -/// \brief Make a node which aggregates input batches, optionally grouped by keys. +/// \brief Make a node which aggregates input batches, optionally grouped by keys and +/// optionally segmented by segment-keys. Both keys and segment-keys determine the group. +/// However segment-keys are also used for determining grouping segments, which should be +/// large, and allow streaming a partial aggregation result after processing each segment. Review Comment: Sounds right. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org