felipecrv opened a new pull request, #34408:
URL: https://github.com/apache/arrow/pull/34408
Bonus: add `ArrayData::IsValid()` to make it consistent with `Array` and
`ArraySpan`.
### Rationale for this change
This is the proposed fix to #34361 plus the addition of more APIs dealing
with validity/nullity.
### What changes are included in this PR?
This PR changes the behavior of `IsNull` and `IsValid` in `Array`,
`ArrayData`, and `ArraySpan`.
It preserves the behavior of `MayHaveNulls`, `GetNullCount` and introduces
new member functions to `Array`, `ArrayData`, and `ArraySpan`:
- `bool HasValidityBitmap() const`
- `bool MayHaveLogicalNulls() const`
- `int64_t ComputeLogicalNullCount() const`
### Are these changes tested?
Yes.
### Are there any user-facing changes?
Yes. See above.
Breakage with these changes can only happen if users rely on `IsNull(i)`
always returning `true` for union types, but we have users reporting that the
current behavior or broken #34315. This is why the behavior of `IsNull` and
`IsValid` is changing.,
**This PR contains a "Critical Fix".**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
