kou commented on code in PR #483:
URL: https://github.com/apache/arrow-adbc/pull/483#discussion_r1122639196
##########
ruby/red-adbc.gemspec:
##########
@@ -52,7 +52,7 @@ Gem::Specification.new do |spec|
spec.files += Dir.glob("lib/**/*.rb")
spec.extensions = ["dependency-check/Rakefile"]
- spec.add_runtime_dependency("red-arrow")
+ spec.add_runtime_dependency("red-arrow", "<11.0.0")
Review Comment:
Ah, OK. Can we try the following? This will install old `red-arrow` when
system Arrow GLib is old.
```diff
diff --git a/ci/scripts/glib_test.sh b/ci/scripts/glib_test.sh
index 51d955b..987cb17 100755
--- a/ci/scripts/glib_test.sh
+++ b/ci/scripts/glib_test.sh
@@ -74,6 +74,14 @@ test_subproject() {
gem_flags='-- --with-cflags="-D_LIBCPP_DISABLE_AVAILABILITY"
--with-cppflags="-D_LIBCPP_DISABLE_AVAILABILITY"'
fi
+ arrow_glib_version=$(pkg-config --modversion arrow-glib | sed -e
's/-SNAPSHOT$//g' || :)
+ if [ -n "${arrow_glib_version}" ]; then
+ gem install \
+ --install-dir "${build_dir}/gems" \
+ --version ${arrow_glib_version} \
+ red-arrow \
+ -- ${gem_flags}
+ fi
gem install --install-dir "${build_dir}/gems" pkg/*.gem -- ${gem_flags}
popd
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
