viirya commented on code in PR #3715:
URL: https://github.com/apache/arrow-rs/pull/3715#discussion_r1123583931
##########
arrow-array/src/array/dictionary_array.rs:
##########
@@ -402,6 +403,44 @@ impl<K: ArrowPrimitiveType> DictionaryArray<K> {
// Offsets were valid before and verified length is greater than or
equal
Self::from(unsafe { builder.build_unchecked() })
}
+
+ /// Returns `PrimitiveDictionaryBuilder` of this dictionary array for
mutating
+ /// its keys and values if the underlying data buffer is not shared by
others.
+ pub fn into_primitive_dict_builder<V>(
+ self,
+ ) -> Result<PrimitiveDictionaryBuilder<K, V>, Self>
+ where
+ V: ArrowPrimitiveType,
+ {
+ if !self.value_type().is_primitive() {
+ return Err(self);
+ }
+
+ let key_array = as_primitive_array::<K>(self.keys()).clone();
+ let value_array = as_primitive_array::<V>(self.values()).clone();
+
+ drop(self.data);
Review Comment:
Yea, this drops self ref count.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
