icexelloss commented on PR #34311: URL: https://github.com/apache/arrow/pull/34311#issuecomment-1452616880
@rtpsw I have finished reviewing the aggregate node changes and half way through the grouper changes. In addition to the comments I made here, I've also consolidated some the my comments into this PR to you branch: https://github.com/apache/arrow/pull/34311 Please take a look and merge it if you can. So far the general approach looks good I will try to finish up reviewing grouper changes tomorrow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
