jaylmiller commented on code in PR #5433:
URL: https://github.com/apache/arrow-datafusion/pull/5433#discussion_r1123839102
##########
benchmarks/parquet.rs:
##########
@@ -178,6 +299,22 @@ async fn exec_scan(
Ok(result.iter().map(|b| b.num_rows()).sum())
}
+async fn exec_sort(
+ ctx: &SessionContext,
+ expr: &[PhysicalSortExpr],
+ test_file: &TestParquetFile,
+ debug: bool,
+) -> Result<()> {
+ let scan = test_file.create_scan(lit(true)).await?;
Review Comment:
Its only used in one other place in the codebase, so changing that method
signature should be fine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
