MachaelLee commented on code in PR #3795:
URL: https://github.com/apache/arrow-rs/pull/3795#discussion_r1124114704
##########
arrow-cast/src/parse.rs:
##########
@@ -76,12 +42,14 @@ use chrono::prelude::*;
/// "2023-01-01 040506 +07:30:00",
/// "2023-01-01 04:05:06.789 PST",
/// "2023-01-01 04:05:06.789 -08",
-#[inline]
-pub fn string_to_timestamp_nanos(s: &str) -> Result<i64, ArrowError> {
+pub fn string_to_datetime<T: TimeZone>(
Review Comment:
There is a question here:
if I want to parse a string with time zone, what should I do with
`string_to_datetime`? Do I have to use `string_to_timestamp_nanos` ?
The precondition is I do not know the format of timestamp-like string.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
