Jefffrey commented on code in PR #5343:
URL: https://github.com/apache/arrow-datafusion/pull/5343#discussion_r1124338686
##########
datafusion/expr/src/logical_plan/builder.rs:
##########
@@ -545,14 +545,22 @@ impl LogicalPlanBuilder {
match (&l.relation, &r.relation) {
(Some(lr), Some(rr)) => {
- let l_is_left =
-
self.plan.schema().field_with_qualified_name(lr, &l.name);
- let l_is_right =
- right.schema().field_with_qualified_name(lr,
&l.name);
- let r_is_left =
-
self.plan.schema().field_with_qualified_name(rr, &r.name);
- let r_is_right =
- right.schema().field_with_qualified_name(rr,
&r.name);
+ let l_is_left =
self.plan.schema().field_with_qualified_name(
+ &lr.as_table_reference(),
Review Comment:
How do you mean?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
