mapleFU commented on code in PR #14341:
URL: https://github.com/apache/arrow/pull/14341#discussion_r1124583494
##########
cpp/src/parquet/encoding.cc:
##########
@@ -3265,6 +3420,14 @@ std::unique_ptr<Encoder> MakeEncoder(Type::type
type_num, Encoding::type encodin
default:
throw ParquetException("DELTA_LENGTH_BYTE_ARRAY only supports
BYTE_ARRAY");
}
+ } else if (encoding == Encoding::DELTA_BYTE_ARRAY) {
+ switch (type_num) {
+ case Type::BYTE_ARRAY:
+ return std::make_unique<DeltaByteArrayEncoder<ByteArrayType>>(descr,
pool);
+ default:
+ throw ParquetException("DELTA_BYTE_ARRAY only supports BYTE_ARRAY");
Review Comment:
Seems standard says it support FIXED_LENGTH_BYTE_ARRAY. We can add a todo
here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
