tustvold commented on code in PR #3796:
URL: https://github.com/apache/arrow-rs/pull/3796#discussion_r1124649504
##########
object_store/src/memory.rs:
##########
@@ -238,13 +240,13 @@ impl ObjectStore for InMemory {
}
async fn copy(&self, from: &Path, to: &Path) -> Result<()> {
- let data = self.get_bytes(from).await?;
+ let data = self.entry(from).await?;
Review Comment:
I think this should probably generate a new last modified timestamp
##########
object_store/src/memory.rs:
##########
@@ -238,13 +240,13 @@ impl ObjectStore for InMemory {
}
async fn copy(&self, from: &Path, to: &Path) -> Result<()> {
- let data = self.get_bytes(from).await?;
+ let data = self.entry(from).await?;
self.storage.write().insert(to.clone(), data);
Ok(())
}
async fn copy_if_not_exists(&self, from: &Path, to: &Path) -> Result<()> {
- let data = self.get_bytes(from).await?;
+ let data = self.entry(from).await?;
Review Comment:
Ditto here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
