jorisvandenbossche commented on a change in pull request #8672:
URL: https://github.com/apache/arrow/pull/8672#discussion_r527031173
##########
File path: python/pyarrow/tests/test_parquet.py
##########
@@ -2008,6 +2008,19 @@ def test_filters_inclusive_set(tempdir,
use_legacy_dataset):
assert 'c' not in result_df['string'].values
assert False not in result_df['boolean'].values
+ dataset = pq.ParquetDataset(
+ base_path, filesystem=fs,
+ filters=[('integer', 'in', [1]), ('string', 'in', ('a', 'b')),
+ ('boolean', 'not in', {False})],
+ use_legacy_dataset=use_legacy_dataset
+ )
+ table = dataset.read()
+ result_df = (table.to_pandas().reset_index(drop=True))
+
+ assert 0 not in result_df['integer'].values
+ assert 'c' not in result_df['string'].values
+ assert False not in result_df['boolean'].values
+
Review comment:
Can you also add a test to assert the error you get when passing an
invalid "in" filter (like `("col", "in", 4)`)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
