wgtmac commented on code in PR #34416: URL: https://github.com/apache/arrow/pull/34416#discussion_r1125491743
########## cpp/src/arrow/adapters/orc/util.h: ########## @@ -35,8 +35,9 @@ Result<std::shared_ptr<DataType>> GetArrowType(const liborc::Type* type); Result<ORC_UNIQUE_PTR<liborc::Type>> GetOrcType(const Schema& schema); -Status AppendBatch(const liborc::Type* type, liborc::ColumnVectorBatch* batch, - int64_t offset, int64_t length, arrow::ArrayBuilder* builder); +ARROW_EXPORT Status AppendBatch(const liborc::Type* type, Review Comment: I have to mark them as `ARROW_EXPORT`. Otherwise the windows build will complain unresolved references for the new tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
