icexelloss commented on code in PR #34311:
URL: https://github.com/apache/arrow/pull/34311#discussion_r1125573811
##########
cpp/src/arrow/compute/exec.h:
##########
@@ -240,6 +246,8 @@ struct ARROW_EXPORT ExecBatch {
ExecBatch Slice(int64_t offset, int64_t length) const;
+ Result<ExecBatch> SelectValues(const std::vector<int>& ids) const;
Review Comment:
"Getting key fields out of a batch" seems something that is universally
needed for any operator that need "key" that's why I found it surprising that
we needed to add such functionality for segment aggregation. Seems like we
added yet another way to "extract keys" (we needed to extract keys also in, for
example, asof join, which is done also differently).
Probably can be follow up but I do feel there are too many ways to extract
key from exec batches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
