rtpsw commented on PR #34311: URL: https://github.com/apache/arrow/pull/34311#issuecomment-1455078010
> > Also, it seems the testing of the new segmenter classes are lacky - can you add some unittest for the segmenter classes? (particular to cover edge cases) > > The current test-cases cover several edge cases, including various errors. I'll see what I can come up with to cover more. What edge cases did you have in mind? I added test-cases in the [recent commit](https://github.com/apache/arrow/pull/34311/commits/218e04ce50d6aae792b797573c2111aa3e5912a3). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
