tustvold commented on issue #4628: URL: https://github.com/apache/arrow-datafusion/issues/4628#issuecomment-1455089509
> However, now that LogicalPlan supports PartialEq I think maybe we could just use that to check if any changes were made This is not a particularly cheap operation, involving a lot of string comparisons. I think having the return value indicate if changes have been made as in your original example makes sense to me. My point was if we remove the Arc we need to be careful to move LogicalPlan and avoid cloning, as any clone is then a deep clone of the entire tree, and so we need to pass in an owned value -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
