lidavidm commented on code in PR #489:
URL: https://github.com/apache/arrow-adbc/pull/489#discussion_r1126368364
##########
java/driver/jdbc/src/main/java/org/apache/arrow/adbc/driver/jdbc/JdbcConnection.java:
##########
@@ -254,6 +254,7 @@ public void setIsolationLevel(IsolationLevel level) throws
AdbcException {
@Override
public void close() throws Exception {
connection.close();
+ allocator.close();
Review Comment:
Can we use AutoCloseables here so that an exception raised by one of the
close() methods won't affect the other?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
