felipecrv commented on code in PR #34195: URL: https://github.com/apache/arrow/pull/34195#discussion_r1126917285
########## cpp/src/arrow/compute/kernels/vector_run_end_encode_test.cc: ########## @@ -0,0 +1,211 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include <gtest/gtest.h> + +#include "arrow/array.h" +#include "arrow/builder.h" +#include "arrow/compute/api_vector.h" +#include "arrow/testing/gtest_util.h" +#include "arrow/util/logging.h" +#include "arrow/util/ree_util.h" + +namespace arrow { +namespace compute { + +namespace { + +struct REETestData { + static REETestData JSON(std::shared_ptr<DataType> data_type, std::string input_json, + std::string expected_values_json, + std::string expected_run_ends_json, int64_t input_offset = 0) { + auto input_array = ArrayFromJSON(data_type, input_json); + REETestData result; + result.input = input_array->Slice(input_offset); + result.expected_values = ArrayFromJSON(data_type, expected_values_json); + result.expected_run_ends_json = std::move(expected_run_ends_json); + result.string = input_json; + return result; + } + + static REETestData NullArray(int64_t input_length, int64_t input_offset = 0) { + auto input_array = std::make_shared<arrow::NullArray>(input_length); + REETestData result; + result.input = input_array->Slice(input_offset); + const int64_t input_slice_length = result.input->length(); + result.expected_values = + std::make_shared<arrow::NullArray>(input_slice_length > 0 ? 1 : 0); + result.expected_run_ends_json = + input_slice_length > 0 ? "[" + std::to_string(input_slice_length) + "]" : "[]"; + result.string = "[null * " + std::to_string(input_slice_length) + "]"; + return result; + } + + template <typename ArrowType> + static REETestData TypeMinMaxNull() { + using CType = typename ArrowType::c_type; + REETestData result; + NumericBuilder<ArrowType> builder; + ARROW_EXPECT_OK(builder.Append(std::numeric_limits<CType>::min())); + ARROW_EXPECT_OK(builder.AppendNull()); + ARROW_EXPECT_OK(builder.Append(std::numeric_limits<CType>::max())); + result.input = builder.Finish().ValueOrDie(); + result.expected_values = result.input; + result.expected_run_ends_json = "[1, 2, 3]"; + result.string = "Type min, max, & null values"; + return result; + } + + std::shared_ptr<Array> input; + std::shared_ptr<Array> expected_values; + std::string expected_run_ends_json; + // only used for gtest output + std::string string; +}; + +} // namespace + +class TestRunEndEncodeDecode : public ::testing::TestWithParam< + std::tuple<REETestData, std::shared_ptr<DataType>>> { + public: + void AddArtificialOffsetInChildArray(ArrayData* array, int64_t offset) { + auto& child = array->child_data[1]; + auto builder = MakeBuilder(child->type).ValueOrDie(); + ARROW_CHECK_OK(builder->AppendNulls(offset)); Review Comment: Thank you for the tip. Done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
