lidavidm commented on code in PR #490:
URL: https://github.com/apache/arrow-adbc/pull/490#discussion_r1126939618
##########
go/adbc/driver/flightsql/flightsql_adbc_test.go:
##########
@@ -838,6 +875,34 @@ func (ts *TimeoutTestSuite) TestGetFlightInfoTimeout() {
ts.NotEqual(adbc.StatusNotImplemented, adbcErr.Code)
}
+func (ts *TimeoutTestSuite) TestDontTimeout() {
Review Comment:
Can we also add a test that should timeout? e.g. set the timeout to 0.01
seconds and ensure it actually fails.
##########
go/adbc/driver/flightsql/utils.go:
##########
@@ -32,7 +32,7 @@ func adbcFromFlightStatus(err error) error {
switch status.Code(err) {
case codes.OK:
return nil
- case codes.Canceled:
+ case codes.Canceled, codes.DeadlineExceeded:
Review Comment:
there's a separate TIMEOUT status:
https://github.com/apache/arrow-adbc/blob/fc01c31c95b48cdc22f0780d1498d89dd20563f9/go/adbc/adbc.go#L134
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
