icexelloss commented on code in PR #34311:
URL: https://github.com/apache/arrow/pull/34311#discussion_r1127045355
##########
cpp/src/arrow/compute/kernels/hash_aggregate_test.cc:
##########
@@ -1917,57 +2243,7 @@ TEST(GroupBy, MinMaxBinary) {
}
}
-TEST(GroupBy, MinMaxFixedSizeBinary) {
Review Comment:
The original test is called "MinMaxBinary" and it seems you renamed it to
"MinMaxFixedSizeBinary" and deleted the original "MinMaxFixedSizeBinary" test
##########
cpp/src/arrow/compute/kernels/hash_aggregate_test.cc:
##########
@@ -1917,57 +2243,7 @@ TEST(GroupBy, MinMaxBinary) {
}
}
-TEST(GroupBy, MinMaxFixedSizeBinary) {
Review Comment:
The original test above is called "MinMaxBinary" and it seems you renamed it
to "MinMaxFixedSizeBinary" and deleted the original "MinMaxFixedSizeBinary" test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
