Fokko commented on code in PR #34429:
URL: https://github.com/apache/arrow/pull/34429#discussion_r1127062021
##########
python/pyarrow/_dataset_parquet.pyx:
##########
@@ -209,6 +209,26 @@ cdef class ParquetFileFormat(FileFormat):
def make_fragment(self, file, filesystem=None,
Expression partition_expression=None, row_groups=None):
+ """
+ Make a FileFragment from a given file.
+
+ Parameters
+ ----------
+ file : file-like object, path-like or str
+ The file or file path to make a fragment from.
+ filesystem : Filesystem, optional
+ If `filesystem` is given, `file` must be a string and specifies
+ the path of the file to read from the filesystem.
+ partition_expression : Expression, optional
+ The filter expression.
+ row_groups : Iterable, optional
Review Comment:
Thanks @westonpace. I'd love to add types
https://github.com/apache/arrow/issues/32609 but right now it is just guessing
indeed.
I just checked, and an empty list `[]` is allowed, and will not ready any
row groups, and return an empty table. Setting it to `None` will return all the
row groups.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
