jorgecarleitao commented on pull request #8709: URL: https://github.com/apache/arrow/pull/8709#issuecomment-730868602
Hi, thanks a lot for the feedback @andygrove and @alamb . I have changed this PR in the following ways: 1. removed all changes wrt to the `filter` and just kept the `MutableDataArray` construct for the join, to not mix the changes. 2. Made "on" be `Vec<(String, String)>`. The tests are not passing, but I will work on them over the weekend. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
