wgtmac commented on code in PR #34461:
URL: https://github.com/apache/arrow/pull/34461#discussion_r1127330787
##########
cpp/src/parquet/arrow/reader.h:
##########
@@ -249,6 +249,13 @@ class PARQUET_EXPORT FileReader {
virtual ::arrow::Status ReadRowGroup(int i, std::shared_ptr<::arrow::Table>*
out) = 0;
+ virtual ::arrow::Status WillNeedRowGroups(const std::vector<int>& row_groups,
+ const std::vector<int>&
column_indices) = 0;
Review Comment:
+1 for @westonpace's suggestion.
In addition, what if `WillNeedRowGroups` (w/ or w/o same inputs) has been
called more than once? Maintaining the state is rather tricky according to my
experience. If the new function only issues I/O hints to the
`RandomAccessFile`, probably it is much easier to reason about the behavior
directly from `RandomAccessFile`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
