alamb commented on code in PR #5497:
URL: https://github.com/apache/arrow-datafusion/pull/5497#discussion_r1127909977
##########
datafusion/common/src/config.rs:
##########
@@ -397,6 +397,13 @@ impl ConfigOptions {
Self::default()
}
+ /// Creates a new [`ConfigOptions`] with extensions set to provided value
+ pub fn with_extensions(extensions: Extensions) -> Self {
Review Comment:
The benefit of this style is that he naturally extends to setting other
fields (rather than having to have a specialize constructor for each field
that we want to set)
##########
datafusion/common/src/config.rs:
##########
@@ -397,6 +397,13 @@ impl ConfigOptions {
Self::default()
}
+ /// Creates a new [`ConfigOptions`] with extensions set to provided value
+ pub fn with_extensions(extensions: Extensions) -> Self {
Review Comment:
The benefit of this style is that it naturally extends to setting other
fields (rather than having to have a specialize constructor for each field
that we want to set)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
