icexelloss commented on code in PR #34311:
URL: https://github.com/apache/arrow/pull/34311#discussion_r1128109837
##########
cpp/src/arrow/compute/kernels/hash_aggregate_test.cc:
##########
@@ -72,6 +73,12 @@ using internal::ToChars;
namespace compute {
namespace {
+bool kDefaultUseThreads = false;
Review Comment:
This is a bit confusing - it seems that we only use this default in segment
aggregation in two places, and this is also not the default for hash
aggregation? We can probably remove this variable and specify explicitly in
segment aggregation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
