kou commented on code in PR #34482:
URL: https://github.com/apache/arrow/pull/34482#discussion_r1128529424
##########
.github/workflows/go.yml:
##########
@@ -369,3 +369,41 @@ jobs:
- name: Test
shell: bash
run: ci/scripts/go_test.sh $(pwd)
+
+ linux-arm:
Review Comment:
`docker-arm` may be better for consistency.
##########
.github/workflows/go.yml:
##########
@@ -369,3 +369,41 @@ jobs:
- name: Test
shell: bash
run: ci/scripts/go_test.sh $(pwd)
+
+ linux-arm:
+ name: ARM64 Debian 11 GO ${{ matrix.go }}
+ runs-on: ["arm", "linux"]
+ if: ${{ !contains(github.event.pull_request.title, 'WIP') }}
+ timeout-minutes: 60
+ strategy:
+ matrix:
+ go: [1.17]
+ env:
+ GO: ${{ matrix.go }}
+ ARROW_ENABLE_TIMING_TESTS: "OFF"
+ ARCH: arm64v8
+ ARROW_CI_MODULES: "GO"
Review Comment:
We can remove this. This is only for Travis CI.
##########
.github/workflows/go.yml:
##########
@@ -369,3 +369,41 @@ jobs:
- name: Test
shell: bash
run: ci/scripts/go_test.sh $(pwd)
+
+ linux-arm:
+ name: ARM64 Debian 11 GO ${{ matrix.go }}
+ runs-on: ["arm", "linux"]
+ if: ${{ !contains(github.event.pull_request.title, 'WIP') }}
+ timeout-minutes: 60
+ strategy:
+ matrix:
+ go: [1.17]
+ env:
+ GO: ${{ matrix.go }}
+ ARROW_ENABLE_TIMING_TESTS: "OFF"
Review Comment:
We can remove this. This is only for C++.
##########
.github/workflows/go.yml:
##########
@@ -369,3 +369,41 @@ jobs:
- name: Test
shell: bash
run: ci/scripts/go_test.sh $(pwd)
+
+ linux-arm:
+ name: ARM64 Debian 11 GO ${{ matrix.go }}
+ runs-on: ["arm", "linux"]
+ if: ${{ !contains(github.event.pull_request.title, 'WIP') }}
+ timeout-minutes: 60
+ strategy:
+ matrix:
+ go: [1.17]
+ env:
+ GO: ${{ matrix.go }}
+ ARROW_ENABLE_TIMING_TESTS: "OFF"
+ ARCH: arm64v8
+ ARROW_CI_MODULES: "GO"
+ DOCKER_IMAGE_ID: debian-go
+ steps:
+ - name: Checkout Arrow
+ uses: actions/checkout@v3
+ with:
+ fetch-depth: 0
+ submodules: recursive
+ - name: Setup Python
+ run: |
+ sudo apt install -y --no-install-recommends python3 python3-pip
Review Comment:
Can we unify this job to the existing `docker` job by using `apt` in the
existing `docker` job too?
##########
.github/workflows/go.yml:
##########
@@ -369,3 +369,41 @@ jobs:
- name: Test
shell: bash
run: ci/scripts/go_test.sh $(pwd)
+
+ linux-arm:
+ name: ARM64 Debian 11 GO ${{ matrix.go }}
Review Comment:
GO -> Go
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
