kou commented on code in PR #34488:
URL: https://github.com/apache/arrow/pull/34488#discussion_r1128548518


##########
.github/workflows/go.yml:
##########
@@ -308,7 +308,9 @@ jobs:
         run: go install honnef.co/go/tools/cmd/staticcheck@${{ 
matrix.staticcheck }}
       - name: Build
         shell: bash
-        run: ci/scripts/go_build.sh $(pwd)
+        run: |
+           echo 
"PKG_CONFIG_PATH=/usr/local/Cellar/openssl@3/3.0.8/lib/pkgconfig:$PKG_CONFIG_PATH"
 >> $GITHUB_ENV

Review Comment:
   This doesn't affect in this step.
   
   We need a separated step:
   
   ```yaml
   - name: Prepare PKG_CONFIG_PATH
     shell: bash
     run: |
       echo "PKG_CONFIG_PATH=$(brew --prefix 
openssl)/lib/pkgconfig:$PKG_CONFIG_PATH" >> $GITHUB_ENV
   - name: Build
     shell: bash
     run: ci/scripts/go_build.sh $(pwd)
   ...
   ```
   
   And this change causes YAML syntax error: 
https://github.com/apache/arrow/actions/runs/4358242702/workflow#L308
   
   I think that the indentation of this line is a problem.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to