alamb commented on code in PR #5491:
URL: https://github.com/apache/arrow-datafusion/pull/5491#discussion_r1128598560
##########
datafusion/physical-expr/src/planner.rs:
##########
@@ -197,6 +197,16 @@ pub fn create_physical_expr(
rhs,
input_schema,
)?)),
+ (
+ DataType::Interval(_),
Review Comment:
👍
##########
datafusion/core/tests/sqllogictests/test_files/timestamps.slt:
##########
@@ -191,3 +191,24 @@ query P
SELECT DATE_TRUNC('second', '2022-08-03 14:38:50Z');
----
2022-08-03T14:38:50
+
+# Test that interval can add a timestamp
Review Comment:
I see tests here for `timestamp + interval` and `interval + timestamp` (e.g.
`SELECT INTERVAL '8' DAY + timestamp '2013-07-01 12:00:00';`)
I don't see tests for `date + timestamp` and `timestamp + date` -- maybe
that is what you meant?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
