yevgenypats commented on code in PR #34343:
URL: https://github.com/apache/arrow/pull/34343#discussion_r1128671750
##########
go/arrow/csv/reader.go:
##########
@@ -731,15 +731,19 @@ func (r *Reader) parseList(field array.Builder, str
string) {
field.AppendNull()
return
}
- if !(strings.HasPrefix(str, "{") || strings.HasSuffix(str, "}")) {
+ if !(strings.HasPrefix(str, "{") && strings.HasSuffix(str, "}")) {
r.err = errors.New("invalid list format. should start with '{'
and end with '}'")
- field.AppendNull()
return
}
str = strings.TrimPrefix(str, "{")
str = strings.TrimSuffix(str, "}")
Review Comment:
I can change this but I feel the explicit way is clearer and potentially
more efficient. But let me know if you want it the other way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
