mslapek commented on PR #5515: URL: https://github.com/apache/arrow-datafusion/pull/5515#issuecomment-1460130436
@alamb These docs were really missing. This PR is great. TBH I was considering to make (non-object safe) trait `UserDefinedLogicalNodeCore: Eq, Hash` (notice **Core**) and add a blanket implementation `UserDefinedLogicalNodeCore` -> `UserDefinedLogicalNode`. This would avoid the mentioned boilerplate (`as_any`, `dyn_eq`, `dyn_hash`) from the implementer side. @alamb What do you think about the idea? 💡 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
