amoeba commented on PR #34477: URL: https://github.com/apache/arrow/pull/34477#issuecomment-1460931841
Thanks @thisisnic for the 👀 . You'll see I pushed up a couple of commits after your review related to type casting when iterating over GcsOptions' default_metadata. The issue had to with Arrow's use of signed ints for container sizes where cpp11 (and the STL) uses signed ints. I ended up with a static_cast which isn't totally safe w/o a check but I think this is safe enough in practice. Aside from any comments on the above, this is ready for a merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
