Jefffrey commented on code in PR #5343:
URL: https://github.com/apache/arrow-datafusion/pull/5343#discussion_r1130673179
##########
datafusion/core/src/execution/context.rs:
##########
@@ -329,19 +329,19 @@ impl SessionContext {
or_replace,
}) => {
let input = Arc::try_unwrap(input).unwrap_or_else(|e|
e.as_ref().clone());
- let table = self.table(&name).await;
+ let table = self.table(name.clone()).await;
Review Comment:
Yeah this looks good, as it looks better without the clone, however I think
`to_owned_reference(...)` will clone the underlying strings anyway:
https://github.com/Jefffrey/arrow-datafusion/blob/57ce66c24858cedac4f2c56194ea72f84d7be2f5/datafusion/common/src/table_reference.rs#L192-L212
Edit: implemented something similar
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
