tustvold commented on code in PR #3818:
URL: https://github.com/apache/arrow-rs/pull/3818#discussion_r1131334625
##########
arrow-data/src/data/mod.rs:
##########
@@ -598,14 +594,8 @@ impl ArrayData {
/// This function panics if:
/// * the buffer is not byte-aligned with type T, or
/// * the datatype is `Boolean` (it corresponds to a bit-packed buffer
where the offset is not applicable)
- #[inline]
Review Comment:
Because buffers and typed_data are not inline, and this function is not
being called in any hot loops - basically it was unnecessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
