mslapek commented on code in PR #5521:
URL: https://github.com/apache/arrow-datafusion/pull/5521#discussion_r1131466927
##########
datafusion/expr/src/logical_plan/extension.rs:
##########
@@ -94,6 +94,9 @@ pub trait UserDefinedLogicalNode: fmt::Debug + Send + Sync {
/// Update the hash `state` with this node requirements from
/// [`Hash`].
///
+ /// Note: consider using [`UserDefinedLogicalNodeCore`] instead of
Review Comment:
That's a great hint for people doing the upgrade. 👏
Next time I write docs I'll take a while to take the perspective of a person
doing an update. 💡
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
