comphead commented on code in PR #5520:
URL: https://github.com/apache/arrow-datafusion/pull/5520#discussion_r1131495741
##########
datafusion/core/src/datasource/datasource.rs:
##########
@@ -97,6 +97,16 @@ pub trait TableProvider: Sync + Send {
fn statistics(&self) -> Option<Statistics> {
None
}
+
+ /// Insert into this table
+ async fn insert_into(
+ &self,
+ _state: &SessionState,
+ _input: &LogicalPlan,
+ ) -> Result<()> {
+ let msg = "Insertion not implemented for this table".to_owned();
Review Comment:
Imho `TableProvider` should have its own name.... I can investigate the
purpose of having `name`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
