alamb commented on PR #5511: URL: https://github.com/apache/arrow-datafusion/pull/5511#issuecomment-1462706360
> > If this syntax is not deprecated, it should probably be tested as well? > I agree it should be tested. I will review our existing coverage and see if anything else is needed I reviewed the use of `binary_expr` and I think there is plenty of other coverage (see https://github.com/search?q=repo%3Aapache%2Farrow-datafusion%20binary_expr&type=code) I didn't see much focused testing for the functions defined in in https://github.com/apache/arrow-datafusion/blob/main/datafusion/expr/src/expr_fn.rs https://github.com/apache/arrow-datafusion/blob/main/datafusion/expr/src/expr_fn.rs Thus I conclude this PR doesn't impact the test coverage for expression creation functions. If we want to cover the functions in `expr_fn.rs` more deliberately or in a more structured way, I think we could do it as a follow on PR / add tests specifically for that coverage, rather than rely on tests for other functionality (simplification) covering somewhat unrelated functionality (expr creation) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
