prashanthbdremio commented on code in PR #34424:
URL: https://github.com/apache/arrow/pull/34424#discussion_r1131638059
##########
java/vector/src/main/java/org/apache/arrow/vector/BigIntVector.java:
##########
@@ -71,7 +73,11 @@ public BigIntVector(String name, FieldType fieldType,
BufferAllocator allocator)
*/
public BigIntVector(Field field, BufferAllocator allocator) {
super(field, allocator, TYPE_WIDTH);
- reader = new BigIntReaderImpl(BigIntVector.this);
+ reader = () -> {
Review Comment:
Thanks for working on this rtadepalli. Instead of the above logic, should we
add a new constructor with a new boolean parameter createReader. We create the
reader based on the boolean flag. And in the getReader if the reader is null,
we throw an exception. Callers who dont need the reader can call the new
constructor, and if they try accessing the reader then they get an exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
