wjones127 commented on PR #478: URL: https://github.com/apache/arrow-adbc/pull/478#issuecomment-1463021509
> It may be useful to return Arrow objects and expose the converter helper? I deemed that a "battle for another day" when working on the R bindings but I suppose you've already written it. Yes, that's certainly the alternative. I was thinking that the interface would be the Rust types, and there would be a converter to/from the Arrow types for C FFI, but going the other way works to. My only thought is if most of the time people will prefer working with the Rust types, then why not use those as the primary interface? > I found it a little difficult to picture what using this API might look like while reading the source Yeah the only reason I don't have examples is I already have them in PRs and I'm running a bit low on steam. But I can point to some of those in the other branches. Using `get_info()`: https://github.com/apache/arrow-adbc/blob/75ba2cef9080b19f4d242d0a03c17db304609d85/rust/tests/test_driver_manager.rs#L65-L87 Using `get_objects()`: https://github.com/apache/arrow-adbc/blob/75ba2cef9080b19f4d242d0a03c17db304609d85/rust/tests/test_driver_manager.rs#L110-L144 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
